Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update compute.json to add ProtectFromScaleIn property to VMScaleSetVM properties #4866

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Update compute.json to add ProtectFromScaleIn property to VMScaleSetVM properties #4866

merged 1 commit into from
Feb 1, 2019

Conversation

ashintre
Copy link
Member

Add ProtectFromScaleIn property to VMScaleSetVM properties

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@ashintre
Update compute.json
c4a48f4 
Add ProtectFromScaleIn property to VMScaleSetVM properties
@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI AutorestCI mentioned this pull request Dec 10, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 10, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#630

@AutorestCI
Copy link

AutorestCI commented Dec 10, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Dec 10, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Dec 10, 2018 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#4151

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@jhendrixMSFT
Copy link
Member

@ashintre is this behavior live?

@AutorestCI
Copy link

AutorestCI commented Dec 10, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Dec 10, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 10, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4240

@AutorestCI AutorestCI mentioned this pull request Dec 10, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Dec 10, 2018 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#4006

@ashintre
Copy link
Member Author

@ashintre is this behavior live?

not yet

@jhendrixMSFT jhendrixMSFT added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Dec 10, 2018
jhendrixMSFT
jhendrixMSFT requested changes Dec 10, 2018
View reviewed changes
Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update when change is live so this can be merged.

@jhendrixMSFT
Copy link
Member

@ashintre still waiting for service deployment?

@ashintre
Copy link
Member Author

ashintre commented Jan 7, 2019

@ashintre still waiting for service deployment?

Yes. Hopefully should be deployed everywhere by the end of next week or so.

@jhendrixMSFT
Copy link
Member

@ashintre hello any update?

@ashintre
Copy link
Member Author

ashintre commented Feb 1, 2019

@ashintre hello any update?

thanks for following up. this is now deployed.

@jhendrixMSFT jhendrixMSFT merged commit 72afb64 into Azure:master Feb 1, 2019
This was referenced Feb 1, 2019
Merged
Merged
yangl900 added a commit to yangl900/azure-rest-api-specs that referenced this pull request Feb 4, 2019
@yangl900
Revert "Update compute.json (Azure#4866)"
e4d2870 
This reverts commit 72afb64.
jhendrixMSFT pushed a commit that referenced this pull request Feb 4, 2019
@yangl900 @jhendrixMSFT
Revert "[AKS] add apiServerAuthorizedIPRanges property" (#5150)
c00c1cb 
* Revert "typo: azure-mgmt-containerservices -> azure-mgmt-containerservice (#5103)"

This reverts commit c8be36b.

* Revert "Add missing Java code gen info to Kusto (#5142)"

This reverts commit 8c304e7.

* Revert "Update compute.json (#4866)"

This reverts commit 72afb64.

* Revert "Add SkillsetOperations to C# code generation settings (#5132)"

This reverts commit b2ed47f.

* Revert "[GuestConfiguration]Update ConfigurationInfo class to include version field (#5131)"

This reverts commit 930987c.

* Revert "Adding new api-version to Microsoft.Security Alerts resource (#4902)"

This reverts commit 93f46f5.

* Revert "Add a spec for policyStates API version 2018-07-01-preview (#5134)"

This reverts commit 84d025e.

* Revert "added link to disk properties for UltraSSD values (#5135)"

This reverts commit e713e24.

* Revert "Undoing unintended removal of a field (#5133)"

This reverts commit e0f2f8c.

* Revert "Run separate instance of OAV (#5026)"

This reverts commit e44239a.

* Revert "Eventhub: Added skipEmptyArchives to Eventhub CaptureDescription (#5105)"

This reverts commit eaf5e5c.

* Revert "Resourcehealth events response (#5116)"

This reverts commit 935baac.

* Revert "Add Helm Events to ACR Schema for Event Grid (#5109)"

This reverts commit 6f4cee5.

* Revert " Creates the "real" API for Scheduled Alert Rules (#5084)"

This reverts commit d847550.

* Revert "Update managedInstances.json (#5114)"

This reverts commit 2072ba5.

* Revert "HDFS FE: Update 2018-11-09 DataLakeStorage Swagger. (#5108)"

This reverts commit 60a8c18.

* Revert "Add dispatch child to LUIS Runtime response (#5100)"

This reverts commit 03581da.

* Revert "Add new field 'proximityPlacementGroup' to properties of HanaInstance (#5107)"

This reverts commit 31fa6a1.

* Revert "fix Go SDK codegen for Microsoft.Insights (#5106)"

This reverts commit b5ac8e3.

* Revert "[AKS] add apiServerAuthorizedIPRanges property (#5101)"

This reverts commit 8d178c3.
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@ashintre @AnuTalluri
Update compute.json (Azure#4866)
f1d4621 
Add ProtectFromScaleIn property to VMScaleSetVM properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

Assignees

@jhendrixMSFT jhendrixMSFT

Labels
DoNotMerge <valid label in PR review process> use to hold merge after approval review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ashintre @AutorestCI @azuresdkci @jhendrixMSFT @kpajdzik